Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add HBN dataset #576

Merged
merged 37 commits into from
Sep 28, 2023
Merged

feat: Add HBN dataset #576

merged 37 commits into from
Sep 28, 2023

Conversation

prassepaul
Copy link
Member

Description

New dataset: HBN data

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

prassepaul and others added 29 commits September 15, 2023 09:13
added from_csv (#504)
d23b81f
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
bf9f7d8 
for more information, see https://pre-commit.ci
Merge https://github.com/aeye-lab/pymovements into feature/gaze_from_csv
83e6629
fix docstring error
4397cb9
@prassepaul
Merge branch 'main' into feature/gaze_from_csv
5aa980a
Merge branch 'feature/gaze_from_csv' of https://github.com/aeye-lab/p…
e4575b5 
…ymovements into feature/gaze_from_csv
docstring error
aa994f0
flake8 issue
16e3946
@prassepaul
Merge branch 'main' into feature/gaze_from_csv
1a0fb31
cyclic import
493efdb
added import to docstring
926e27c
added dataset gaze_on_faces
9b074ae
@prassepaul
Merge branch 'main' into feature/feature-from_ipc
bddc5f4
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
c026c14 
for more information, see https://pre-commit.ci
from_ipc
12f437a
Merge branch 'feature/feature-from_ipc' of https://github.com/aeye-la…
57b65d5 
…b/pymovements into feature/feature-from_ipc
error in path
0370b63
unused arguments
a45c1f3
bug fix
1366a75
fixed time column in feather file
3e50091
@prassepaul
Merge branch 'main' into feature/feature-from_ipc
0837f19
requested changes
6de384b
sbset dataset
8bb3047
flake, pyling, mypy
6515bf6
@prassepaul
Merge branch 'main' into feature/dataset-sbsat
0c3be30
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
cc09b6f 
for more information, see https://pre-commit.ci
bib
16a0b8b
Merge branch 'feature/dataset-sbsat' of https://github.com/aeye-lab/p…
3c55d0a 
…ymovements into feature/dataset-sbsat
hbn dataset
61d7ceb
@prassepaul prassepaul requested a review from dkrako as a code owner September 25, 2023 14:01
@prassepaul prassepaul requested a review from SiQube as a code owner September 25, 2023 14:01
@codecov
Copy link

codecov bot commented Sep 25, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (73793f3) 100.00% compared to head (aa0f2a9) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #576   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           51        52    +1     
  Lines         2234      2258   +24     
  Branches       552       559    +7     
=========================================
+ Hits          2234      2258   +24
Files Coverage Δ
src/pymovements/datasets/__init__.py 100.00% <100.00%> (ø)
src/pymovements/datasets/hbn.py 100.00% <100.00%> (ø)
src/pymovements/datasets/sb_sat.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SiQube
Copy link
Member

SiQube commented Sep 26, 2023

I think here are multiple commit within one PR. let's merge them one by one.

@dkrako dkrako changed the title Feature/dataset hbn feat: Add HBN dataset Sep 28, 2023
dkrako
dkrako requested changes Sep 28, 2023
View reviewed changes
src/pymovements/datasets/hbn.py Outdated Show resolved Hide resolved
@dkrako dkrako merged commit c8ef04d into main Sep 28, 2023
17 checks passed
@dkrako dkrako deleted the feature/dataset-hbn branch September 28, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkrako dkrako dkrako approved these changes

@SiQube SiQube Awaiting requested review from SiQube SiQube is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prassepaul @SiQube @dkrako